Re: [Xen-devel] [PATCH 12/12] xen/gntdev: provide a set of pages for each VMA

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 9 Jan 2015, Stefano Stabellini wrote:
> On Tue, 6 Jan 2015, David Vrabel wrote:
> > From: Jenny Herbert <jennifer.herbert@xxxxxxxxxx>
> > 
> > For each VMA for grant maps, provide the correct array of pages so
> > get_user_pages() on foreign mappings works in PV guests.
> > 
> > Signed-off-by: Jenny Herbert <jennifer.herbert@xxxxxxxxxx>
> > Signed-off-by: David Vrabel <david.vrabel@xxxxxxxxxx>
> > ---
> >  drivers/xen/gntdev.c |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/xen/gntdev.c b/drivers/xen/gntdev.c
> > index 5d73fe8..09e7863 100644
> > --- a/drivers/xen/gntdev.c
> > +++ b/drivers/xen/gntdev.c
> > @@ -870,6 +870,8 @@ static int gntdev_mmap(struct file *flip, struct 
> > vm_area_struct *vma)
> >                                         vma->vm_end - vma->vm_start,
> >                                         set_grant_ptes_as_special, NULL);
> >             }
> > +
> > +           vma->pages = map->pages;
> 
> Shouldn't this be done just for x86 PV guests rather than all the
> callers of gntdev_mmap?

I guess that since on ARM and PVH the pte wouldn't be marked SPECIAL, it
wouldn't make a difference, but it would still be nice to be consistent.


> >     }
> >  
> >     return 0;
> > -- 
> > 1.7.10.4
> > 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel