[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/3] x86: also allow REP STOS emulation acceleration



>>> On 08.01.15 at 20:29, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 08/01/15 15:50, Jan Beulich wrote:
>> +        if ( !buf )
>> +            buf = p_data;
>> +        else
>> +            switch ( bytes_per_rep )
>> +            {
>> +#define CASE(bits, suffix)                                      \
>> +            case (bits) / 8:                                    \
>> +                asm ( "rep stos" #suffix                        \
>> +                      :: "a" (*(const uint##bits##_t *)p_data), \
>> +                         "D" (buf), "c" (*reps)                 \
>> +                      : "memory" );                             \
> 
> This looks as if it needs output clobbers for D and c

Well spotted, will fix.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.