Re: [Xen-devel] [PATCH 2/2] libxl_internal: comment on domain userdata unlock function

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2015-01-07 at 16:57 +0000, Wei Liu wrote:

> > > diff --git a/tools/libxl/libxl_internal.c b/tools/libxl/libxl_internal.c
> > > index 9d8025d..a70214b 100644
> > > --- a/tools/libxl/libxl_internal.c
> > > +++ b/tools/libxl/libxl_internal.c
> > > @@ -458,6 +458,20 @@ out:
> > >  
> > >  void libxl__unlock_domain_userdata(libxl__domain_userdata_lock *lock)
> > >  {
> > > +    /* It's important to unlink the file before closing fd to avoid
> > > +     * such race (if close before unlink):
> >           ^^^^
> > 
> > "to avoid the following race".  "Such" must refer to a thing which
> > precedes.
> > 
> 
> I suppose you (or Ian C) can fix this when committing? Do I need to
> resend?

I've applied both patches and fixed this up.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel