Re: [Xen-devel] [PATCH 3/3] x86/HVM: make hvm_efer_valid() honor guest features

[Tim Deegan <tim@xxxxxxx>]

At 15:23 +0000 on 08 Jan (1420727005), Jan Beulich wrote:
> +    if ( (value & EFER_LMSLE) && !cpu_has_lmsl )
> +        return 0;

I see this bit has no CPUID flag, and the docs don't seem to suggest
that it would ever not be valid.  Are there real CPUs where it can't
be set?

My reviewed-by: stands anyway as this is an improvement over the
current code.  Just wondering whether this needs to go on the list
of interesting edge cazses for Andrew's feature-levelling rewrite. 

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel