Re: [Xen-devel] [OSSTEST PATCH 3/4] Add nested testcase of installing L2 guest VM

[Robert Hu <robert.hu@xxxxxxxxxxxxxxxx>]

On Thu, 2015-01-08 at 10:48 +0000, Wei Liu wrote:
> On Thu, Jan 08, 2015 at 07:34:39AM +0000, Pang, LongtaoX wrote:
> [...]
> > > > ts-debian-install installs a L2 PV guest, which should work even
> > > > without nested HVM enabled for your L1 HVM guest. You're testing
> > > > nested HVM I think it makes more sense to install a L2 HVM guest.
> > > >
> > > [Pang, LongtaoX] Thanks Wei, I will try to re-use the script of
> > > ts-debian-hvm-install as L2, maybe it will make this script become 
> > > complicated.
> > > If it works, there will not be necessary to modify and use 
> > > ts-debian-install
> > > anymore.
> > [Pang, LongtaoX] Hi Wei, for script of ts-debian-hvm-install, as too many 
> > parameters, functions, structure and variables are not suit for L2 
> > installing , 
> > if I re-use and modify as L2, it will make the script become more 
> > convoluted and hard to maintain in later days. 
> > So, I plant to write a new script similar to ts-debian-hvm-install, called 
> > ts-debian-hvm-install-L2 for L2 guest installing. 
> > If you have any concern or other opinions, please tell me, thanks.
> 
> Some foreseeable variables I can think of are bios, disk size and ram
> size, which can be easily grouped together.  Though you may also need
> things like checking whether L2 guest is up and reachable etc.
ts-debian-hvm-install has already been reused/modified to accommodate
nested L1 installation. Adding L2 installation in will make it further
more complex; not good for read and maintenance.
And different from L1 installation, L2 installation will not need too
many packages, just a minimal installation is sufficient. If resued,
preseed configuration will also need to be branched from L1. This is
also for the sake of save time; L2 guest installation shall take more
time, as it's nested.
I would also propose to separate another ts- for L2 installation; don't
spoils ts-debian-hvm-install to be too complex.
> 
> I'm not too convinced that you really need a new script.  But OSSTest
> maintainers may disagree with me. Please wait for them to reply before
> implementing any change.
> 
> Wei.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel