Re: [Xen-devel] [PATCH 1/2] tools/hotplug: introduce XENSTORED_ARGS= in sysconfig file.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2015-01-07 at 17:37 +0100, Olaf Hering wrote:
> It is already used in the runlevel script and the service file.
> It is supposed to replace XENSTORED_TRACE= boolean, which cant be easily
> supported in the xenstored.service file.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> Cc: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> Cc: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
> Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
> Cc: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
>  tools/hotplug/Linux/init.d/sysconfig.xencommons.in | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in 
> b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
> index c12fc8a..f0fa98d 100644
> --- a/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
> +++ b/tools/hotplug/Linux/init.d/sysconfig.xencommons.in
> @@ -21,6 +21,14 @@
>  #XENSTORED=@XENSTORED@
>  
>  ## Type: string
> +## Default: ""
> +#
> +# Additional commandline arguments to start xenstored,
> +# like "--trace-file /var/log/xen/xenstored-trace.log"
> +# See "@sbindir@/xenstored --help" for possible options.

I think you want $XENSTORED here (back reference to the above) to cope
with the possible use of oxenstored.

Alternatively @XENSTORED@ would cause this to refer to the default
xenstored implementation, but I don't think that's quite right.

(TBH, saying "see foo --help for options" almost doesn't need saying)

> +XENSTORED_ARGS=
> +
> +## Type: string
>  ## Default: Not defined, tracing off
>  #
>  # Log xenstored messages
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel