Re: [Xen-devel] [PATCH v2 3/4] sysctl: Add sysctl interface for querying PCI topology

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 01/06/2015 11:55 AM, Wei Liu wrote:
> On Mon, Jan 05, 2015 at 09:18:56PM -0500, Boris Ostrovsky wrote:
> [...]
> >   DEFINE_XEN_GUEST_HANDLE(xen_sysctl_lockprof_op_t);
> >   
> >   /* XEN_SYSCTL_cputopoinfo */
> A bikeshed issue: is it better to just modified the above comment
> instead of adding new trailing comment?
To me the top comment applies to structure definitions as well which is 
why I thought a side comment would be more appropriate.
-boris

> Wei.
>
> > -#define INVALID_TOPOLOGY_ID  (~0U)
> > +#define INVALID_TOPOLOGY_ID  (~0U) /* Also used by pcitopo */

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel