[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 6/7] tools/hotplug: remove EnvironmentFile from xen-qemu-dom0-disk-backend.service

On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote:
> The references Environment file does not exist, and the service file


> does not make use of variables anyway.

In principal the env vars are also for the benefit of the thing launched
by the Exec line too, not just the unit file.

qemu-system-i386 does use getenv() but not in any way which looks
relevant under Xen (e.g. linux-user/main.c uses it, but we don't care).

If someone changes exec to something (e.g. a wrapper) which cares about
envvars they can equally well set EnvironmentFile too. So:

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.