[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen: arm: correct off-by-one error in consider_modules



On Mon, Dec 22, 2014 at 11:54:01AM +0100, Julien Grall wrote:
> Hi Ian,
> 
> On 21/12/2014 12:18, Ian Campbell wrote:
> >By iterating up to <= mi->nr_mods we are running off the end of the boot
> >modules, but more importantly it causes us to then skip the first FDT 
> >reserved
> >region, meaning we might clobber it.
> 
> Oops. Good catch!
> 
> OOI, how did you find it?
> 
> >Signed-off-by: Ian Campbell <ijc@xxxxxxxxxxxxxx>
> 
> Reviewed-by: Julien Grall <julien.grall@xxxxxxxxxx>
> 
> >---
> >For 4.5: I think this bug fix should go in, it fixes a real issue and is low
> >risk.

Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilK@xxxxxxxxxx>
> 
> Agreed.
> 
> >I'll also add to my list of things to consider for backport to 4.4.
> 
> Ditto.
> 
> Regards,
> 
> -- 
> Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.