[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 0/2] Credit2: introduce per-vcpu hard and soft affinity

On Sat, 2014-11-29 at 14:33 -1000, Justin T. Weaver wrote:
> Hello,
Hi Justin,

First of all, this is, overall, a really good submission. The only thing
you need to add is a few references.

For example, you already sent something in the past (an RFC, IIRC).
Mention it in the cover letter (I personally also add a link to the

> I tested this series on a NUMA machine with Dario Faggioli's "fix
> per-socket runqueue setup" patch series applied. Without it, the credit2
> scheduler only creates one run queue, regardless of the type of machine.
Yes, I'll resubmit an updated version of that series soon.

So, how did the testing went? Since you're not saying anything, I
imagine that, at least functionally, everything works, at least as far
as you can tell, isn't it so? :-)

At least as far as soft-affinity is concerned, it should not be too
difficult to collect some numbers, to show that it is bringing benefits,
at least for some workloads.

Do you think you'll be able to do something like that?

When doing this same thing for credit1, here's what I did:


<<This happens because I choose it to happen!>> (Raistlin Majere)
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)

Attachment: signature.asc
Description: This is a digitally signed message part

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.