[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] console: const-ify the arguments for __warn() and __bug()


  • To: xen-devel@xxxxxxxxxxxxx
  • From: Mihai DonÈu <mdontu@xxxxxxxxxxxxxxx>
  • Date: Wed, 10 Dec 2014 14:22:36 +0200
  • Cc: keir@xxxxxxx, ian.campbell@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, ian.jackson@xxxxxxxxxxxxx, tim@xxxxxxx, jbeulich@xxxxxxxx
  • Comment: DomainKeys? See http://domainkeys.sourceforge.net/
  • Delivery-date: Wed, 10 Dec 2014 12:23:07 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=bitdefender.com; b=FUa46v1zjTK2MGxMH8qdpbWf8NQEqeYr5OxwFaCka+5Kb8uTt9byLCJzyYY/isSkPfUZ4qvOkUzkmbW8ESpA3i1mlR5GP1eCl6CPJr1PgRbplBB4UbxtSckShlTcTi86IZont8WtOnS1ozSG7+KeBscwtIGI0pfEjJIv5KnuO8l/g/IhCzR6jnstOhc2dy1VfQclEPP1Fxnoq/US+fgeZDoKn3FhQl6WlA4j/AgYxsuJRt6shEMgFt5q+fn5DY8ySPR8BGXAG+cDFNbZwN3hWtighYuJa1ifeJsFnW/0vq0awZegsrd+FByAwo5XBNN8kOOTiLChncIzeaGR0eSqmw==; h=Received:Received:Received:Received:Received:From:To:Cc:Subject:Date:Message-Id:X-Mailer:MIME-Version:Content-Type:Content-Transfer-Encoding:X-BitDefender-Scanner:X-BitDefender-Spam:X-BitDefender-SpamStamp:X-BitDefender-CF-Stamp;
  • List-id: Xen developer discussion <xen-devel.lists.xen.org>

Both __warn() and __bug() take as first parameter the file name of the
current compilation unit (__FILE__). Mark that parameter as constant to
better reflect that.

Signed-off-by: Mihai DonÈu <mdontu@xxxxxxxxxxxxxxx>
Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
---
 xen/drivers/char/console.c | 4 ++--
 xen/include/xen/lib.h      | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
index 2f03259..7807cf2 100644
--- a/xen/drivers/char/console.c
+++ b/xen/drivers/char/console.c
@@ -1138,7 +1138,7 @@ void panic(const char *fmt, ...)
         machine_restart(5000);
 }
 
-void __bug(char *file, int line)
+void __bug(const char *file, int line)
 {
     console_start_sync();
     printk("Xen BUG at %s:%d\n", file, line);
@@ -1146,7 +1146,7 @@ void __bug(char *file, int line)
     panic("Xen BUG at %s:%d", file, line);
 }
 
-void __warn(char *file, int line)
+void __warn(const char *file, int line)
 {
     printk("Xen WARN at %s:%d\n", file, line);
     dump_execution_state();
diff --git a/xen/include/xen/lib.h b/xen/include/xen/lib.h
index f11b49e..8f9cadb 100644
--- a/xen/include/xen/lib.h
+++ b/xen/include/xen/lib.h
@@ -8,8 +8,8 @@
 #include <xen/string.h>
 #include <asm/bug.h>
 
-void noreturn __bug(char *file, int line);
-void __warn(char *file, int line);
+void noreturn __bug(const char *file, int line);
+void __warn(const char *file, int line);
 
 #define BUG_ON(p)  do { if (unlikely(p)) BUG();  } while (0)
 #define WARN_ON(p) do { if (unlikely(p)) WARN(); } while (0)
-- 
2.2.0


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.