Re: [Xen-devel] [PATCH 5/6] libxl: events: Deregister evtchn fd when not needed

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Tue, 2014-12-09 at 11:22 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 5/6] libxl: events: Deregister evtchn fd 
> when not needed"):
> > On Fri, 2014-11-28 at 14:47 +0000, Ian Jackson wrote:
> > > libxl__ev_evtchn_* is always called with the ctx lock held.
> > 
> > For the most part this is implicit due to the caller being in an ao
> > callback, right?
> 
> Yes.
> 
> > > However, that they don't take the lock is contrary to the rules stated
> > > for libxl__ev_* in the doc comment.  That should be fixed for 4.6.
> > 
> > OK.
> 
> Should I take this as an ack ?

There were other comments further down my original review which you
haven't answered. I don't think they were (all) predicated on a
particular answer to the first question (although some were).

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel