Re: [Xen-devel] [PATCH v2 11/19] xen: handle XENMEMF_get_vnumainfo in compat_memory_op

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 01.12.14 at 16:33, <wei.liu2@xxxxxxxxxx> wrote:
> @@ -273,6 +276,33 @@ int compat_memory_op(unsigned int cmd, 
> XEN_GUEST_HANDLE_PARAM(void) compat)
>              break;
>          }
>  
> +        case XENMEM_get_vnumainfo:
> +     {

Hard tab.

> +            enum XLAT_vnuma_topology_info_vdistance vdistance =
> +                XLAT_vnuma_topology_info_vdistance_h;
> +            enum XLAT_vnuma_topology_info_vcpu_to_vnode vcpu_to_vnode =
> +                XLAT_vnuma_topology_info_vcpu_to_vnode_h;
> +            enum XLAT_vnuma_topology_info_vmemrange vmemrange =
> +                XLAT_vnuma_topology_info_vmemrange_h;
> +
> +            if ( copy_from_guest(&cmp.vnuma, compat, 1) )
> +                return -EFAULT;
> +
> +#define XLAT_vnuma_topology_info_HNDL_vdistance_h(_d_, _s_)          \
> +            guest_from_compat_handle((_d_)->vdistance.h, (_s_)->vdistance.h)
> +#define XLAT_vnuma_topology_info_HNDL_vcpu_to_vnode_h(_d_, _s_)              
> \
> +            guest_from_compat_handle((_d_)->vcpu_to_vnode.h, 
> (_s_)->vcpu_to_vnode.h)
> +#define XLAT_vnuma_topology_info_HNDL_vmemrange_h(_d_, _s_)          \
> +            guest_from_compat_handle((_d_)->vmemrange.h, (_s_)->vmemrange.h)
> +
> +            XLAT_vnuma_topology_info(nat.vnuma, &cmp.vnuma);
> +
> +#undef XLAT_vnuma_topology_info_HNDL_vdistance_h
> +#undef XLAT_vnuma_topology_info_HNDL_vcpu_to_vnode_h
> +#undef XLAT_vnuma_topology_info_HNDL_vmemrange_h
> +            break;
> +     }

Again.

With these two fixed and the subject adjusted to name the sub-op
correctly,
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel