[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-xen-4.5 1/3] tools/hotplug: distclean target should remove files generated by configure



On Tue, Dec 02, 2014 at 01:36:20PM -0500, Konrad Rzeszutek Wilk wrote:
> On Tue, Dec 02, 2014 at 04:16:28PM +0100, Daniel Kiper wrote:
> > Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>
> 
> This usage scenario which I can see this being useful (and
> I've tripped over this) is when you rebuild a new version
> from the same repo. As in, this affects developers, but


Lets get it in. It fixes an issues that I keep on tripping
on and it is harmless enough that I don't see a way
for this to cause any regressions.

Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> not end-users and not distros. But perhaps I am missing
> one scenario?
> 
> As such I would lean towards deferring this (and the other
> two) to Xen 4.6.
> 
> Thank you!
> > ---
> >  tools/Makefile         |    3 +++
> >  tools/hotplug/Makefile |    5 ++++-
> >  2 files changed, 7 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/Makefile b/tools/Makefile
> > index af9798a..19b24f3 100644
> > --- a/tools/Makefile
> > +++ b/tools/Makefile
> > @@ -261,6 +261,9 @@ subdir-all-debugger/kdd: .phony
> >  subdir-distclean-firmware: .phony
> >     $(MAKE) -C firmware distclean
> >  
> > +subdir-distclean-hotplug: .phony
> > +   $(MAKE) -C hotplug distclean
> > +
> >  subtree-force-update:
> >  ifeq ($(CONFIG_QEMU_XEN),y)
> >     $(MAKE) qemu-xen-dir-force-update
> > diff --git a/tools/hotplug/Makefile b/tools/hotplug/Makefile
> > index 14ae9a8..a29a522 100644
> > --- a/tools/hotplug/Makefile
> > +++ b/tools/hotplug/Makefile
> > @@ -6,5 +6,8 @@ SUBDIRS-$(CONFIG_NetBSD) += NetBSD
> >  SUBDIRS-$(CONFIG_Linux) += Linux
> >  SUBDIRS-$(CONFIG_FreeBSD) += FreeBSD
> >  
> > -.PHONY: all clean install
> > +.PHONY: all clean distclean install
> >  all clean install: %: subdirs-%
> > +
> > +distclean:
> > +   rm -f Linux/init.d/sysconfig.xencommons Linux/init.d/xencommons 
> > NetBSD/rc.d/xencommons
> > -- 
> > 1.7.10.4
> > 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.