Re: [Xen-devel] [PATCH v4 4/9] xen: introduce XEN_DOMCTL_devour

[Vitaly Kuznetsov <vkuznets@xxxxxxxxxx>]

Julien Grall <julien.grall@xxxxxxxxxx> writes:

> On 03/12/2014 17:16, Vitaly Kuznetsov wrote:
>> diff --git a/xen/include/xen/sched.h b/xen/include/xen/sched.h
>> index a42d0b8..552e4a3 100644
>> --- a/xen/include/xen/sched.h
>> +++ b/xen/include/xen/sched.h
>> @@ -366,6 +366,8 @@ struct domain
>>       bool_t           is_privileged;
>>       /* Which guest this guest has privileges on */
>>       struct domain   *target;
>> +    /* Which guest receives freed memory pages */
>
> It took me a while to understand that the recipient domain is a newly
> created domain, right? It might be worth to add a word here (and maybe
> in assign_pages).

Sure, will add. In case you think renaming 'recipient' to something else
makes sense I'm all in.

>
> With that in mind, the code in assign_pages makes more sense.
>
> Regards,

-- 
  Vitaly

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel