[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.6] libxl, hotplug/Linux: default to phy backend for raw format file



El 26/11/14 a les 18.44, Wei Liu ha escrit:
> On Wed, Nov 26, 2014 at 06:32:21PM +0100, Roger Pau Monné wrote:
>> El 26/11/14 a les 17.55, Wei Liu ha escrit:
>>> Modify libxl and hotplug script to allow raw format file to use phy
>>> backend.
>>>
>>> The block script now tests the path and determine the actual type of
>>> file (block device or regular file) then use the actual type to
>>> determine which branch to run.
>>>
>>> With these changes, plus the current ordering of backend preference (phy
>>>> qdisk > tap), we will use phy backend for raw format file by default.
>>
>> Maybe it's a stupid question, but I remember that last time this changed
>> was attempted it caused problems with local migration. Has this been fixed?
>>
>> I'm asking because there's no comment of this in the commit message, and
>> the code doesn't seem to differ from the first try in 11a63a.
>>
> 
> Yes, it's fixed.
> 
> Actually I think the regression last time was not local migration but
> another problem.
> 
> This patch is different from the last one, libxl won't write
> "physical-device" if the file is regular file. I think last time the
> hotplug script was not run correctly due to that problem.

IMHO it would be good to add that to the commit message.

Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.