Re: [Xen-devel] [PATCH 1/3] x86: tighten page table owner checking in do_mmu_update()

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 20/11/14 10:29, Andrew Cooper wrote:

On 20/11/14 10:11, Jan Beulich wrote:

MMU_MACHPHYS_UPDATE, not manipulating page tables, shouldn't ignore
a bad page table domain being specified.

Also pt_owner can't be NULL when reaching the "out" label, so the
respective check can be dropped.

Yes it can.

Failing

    if ( (pg_owner = get_pg_owner((uint16_t)foreigndom)) == NULL )
    {
        rc = -ESRCH;
        goto out;
    }

around line 3462 will cause pt_owner to be NULL at the out label.

~Andrew

...And I should really double check my reply before I send.  Apologies for the noise.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel