Re: [Xen-devel] [PATCH V2] Decouple SnadyBridge quirk form VTd timeout

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.11.14 at 05:11, <donald.d.dugger@xxxxxxxxx> wrote:
> @@ -237,6 +254,18 @@
>      }
>  }
>  
> +static void __init parse_snb_timeout(const char *s)
> +{
> +
> +     if (*s == '\0')
> +             snb_igd_timeout = SNB_IGD_TIMEOUT;
> +     else
> +             snb_igd_timeout = MILLISECS(simple_strtoul(s, &s, 0));
> +     snb_igd_quirk = 1;
> +     return;
> +}
> +custom_param("snb_igd_timeout", parse_snb_timeout);

Rather than adding a new command line option, can't you simply
re-use (by extending) the existing (boolean) one? And similarly
replace the current variable (using a value of zero to indicate no
quirk) rather than adding another one?

Also note that the if() statement above needs spaces inserted to
match our coding style.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel