Re: [Xen-devel] [v7][RFC][PATCH 06/13] hvmloader/ram: check if guest memory is out of reserved device memory maps

["Chen, Tiejun" <tiejun.chen@xxxxxxxxx>]

On 2014/11/17 18:05, Jan Beulich wrote:
> > > > On 17.11.14 at 08:57, <tiejun.chen@xxxxxxxxx> wrote:
> > --- a/xen/common/memory.c
> > +++ b/xen/common/memory.c
> > @@ -698,10 +698,13 @@ struct get_reserved_device_memory {
> >        unsigned int used_entries;
> >    };
> >
> > -static int get_reserved_device_memory(xen_pfn_t start,
> > -                                      xen_ulong_t nr, void *ctxt)
> > +static int get_reserved_device_memory(xen_pfn_t start, xen_ulong_t nr, u16 seg,
> > +                                      u16 *ids, int cnt, void *ctxt)
> While the approach is a lot better than what you did previously, I still
> don't like you adding 3 new parameters when one would do (calling
> the callback for each SBDF individually): That way you avoid
Do you mean I should do this?

for_each_rmrr_device ( rmrr, bdf, i )
{
         sbdf = PCI_SBDF(seg, rmrr->scope.devices[i]);
         rc = func(PFN_DOWN(rmrr->base_address),
                   PFN_UP(rmrr->end_address) - 
PFN_DOWN(rmrr->base_address),
                   sbdf,        
                   ctxt);

But each different sbdf may occupy one same rmrr entry as I said 
previously, so we have to introduce more codes to filter them as one 
identified entry in the callback.
Thanks
Tiejun

> introducing a hidden dependency on how the VT-d code manages its
> internal data.
>
> Jan
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel