Re: [Xen-devel] [PATCH v3 07/15] libxl: disallow attaching the same device more than once

["Li, Liang Z" <liang.z.li@xxxxxxxxx>]

> > The libxl__device_exists will return 1 if more than one PCI devices are 
> > attached to the guest, no matter the BDFs are identical or not.
>
> That means this check is problematic. I think the original intention was to 
> check on BDFs, however it wasn't thoroughly tested. Sorry.
>
> > I don't understand why to check this condition here, if the same 
> > device was attached more than once the xc_test_assign_device() will return 
> > error, and the libxl__device_pci_add_xenstore() will not be called. It 
> > seems unnecessary.
> > 
>
> It was added to be in line with other devices. However from the look of it 
> PCI devices need special treatment? Do you have some PCI dev backend paths at 
> hand?
>

Backend paths example for tow PCI devices:
/loacal/domain/0/backend/pci/9/0/dev-1/0000:03:10.1
/loacal/domain/0/backend/pci/9/0/key-1/0000:03:10.1

/loacal/domain/0/backend/pci/9/0/dev-2/0000:03:10.2
/loacal/domain/0/backend/pci/9/0/key-2/0000:03:10.2

These paths can help to identify the PCI devices. But I don't think it is a 
good idea to check all the PCI devices in the backend paths.

> Does reverting the said patch help?

> Wei.


I just remove the if (rc == 1) condition check and it works ok.

Liang

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel