Re: [Xen-devel] [OSSTEST PATCH 1/2] target_editfile: Improve doc comment

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-11-14 at 16:27 +0000, Ian Jackson wrote:
> More clearly state which arguments are optional.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  Osstest/TestSupport.pm |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
> index 45ceee9..46b6720 100644
> --- a/Osstest/TestSupport.pm
> +++ b/Osstest/TestSupport.pm
> @@ -521,7 +521,8 @@ sub teditfileex {
>  sub target_editfile_root ($$$;$$) { teditfileex('root',@_); }
>  sub target_editfile      ($$$;$$) { teditfileex('osstest',@_); }
>      # my $code= pop @_;
> -    # my ($ho,$rfile,$lleaf,$rdest) = @_;
> +    # my ($ho,$rfile, $lleaf,$rdest) = @_;
> +    #                 ^^^^^^^^^^^^^ optional
>  
>  sub target_cmd_build ($$$$) {
>      my ($ho,$timeout,$builddir,$script) = @_;



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel