[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.5 0/2] xl/libxl: return and print partial config



On Wed, Nov 12, 2014 at 12:18:32PM -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 12, 2014 at 05:04:23PM +0000, Wei Liu wrote:
> > This small series change the behavior of 
> > libxl_retrieve_domain_configuration,
> > to make it continue to retrieve information from xenstore even if JSON 
> > template
> > is not available.
> > 
> > This change of API behaviour is only internal. Conceptually speaking, any
> > non-zero return value means d_config is partially filled. The chanage just
> > makes it fill in more information (xenstore entries) than before (empty).
> > Caller can still expect zero on success and non-zero on error and act
> > accordingly.
> 
> What are the work-arounds (if any) if this does not go in Xen 4.5?
> 

The first patch to libxl doesn't change external visible behaviour, that
is, 0 on success, non-zero on error. So whether it goes in or not I
don't have very strong opinion. Keep in mind that this API is new so
this first patch wouldn't cause regression in any way.

For the inconsistency between short and long output, no workaround, but
it wouldn't be disastrous.

Wei.

> > 
> > "xl list -l" is now changed to print out the partial configuration, since it
> > needs to be consistent with the short output.
> > 
> > Wei.
> > 
> > Wei Liu (2):
> >   libxl: continue when encounter ERROR_JSON_CONFIG_EMPTY
> >   xl: print out partial configuration in long mode of list command
> > 
> >  tools/libxl/libxl.c      |    6 +++++-
> >  tools/libxl/xl_cmdimpl.c |    6 ++----
> >  2 files changed, 7 insertions(+), 5 deletions(-)
> > 
> > -- 
> > 1.7.10.4
> > 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.