Re: [Xen-devel] [v7][RFC][PATCH 06/13] hvmloader/ram: check if guest memory is out of reserved device memory maps

["Chen, Tiejun" <tiejun.chen@xxxxxxxxx>]

On 2014/11/11 17:42, Jan Beulich wrote:
> > > > On 11.11.14 at 10:35, <tiejun.chen@xxxxxxxxx> wrote:
> > > Have a structure field named e.g. "flags" and a #define consuming
> > > exactly one bit of it. Just like it's being done everywhere else.
> > Like this?
> >
> >    typedef struct xen_domctl_assign_device xen_domctl_assign_device_t;
> >    DEFINE_XEN_GUEST_HANDLE(xen_domctl_assign_device_t);
> >
> > +struct xen_guest_pcidev_info {
> > +    uint8_t bus;
> > +    uint8_t devfn;
> > +    struct {
> > +        uint32_t    force           : 1,
> > +                    reserved        : 31;
> > +    }flags;
> > +};
> I said #define for a reason - with a few exceptions we try to avoid
> using bit fields in the public interface.
Ok,

 typedef struct xen_domctl_assign_device xen_domctl_assign_device_t;
 DEFINE_XEN_GUEST_HANDLE(xen_domctl_assign_device_t);

+/* Currently just one bit to indicate force to check Reserved Device 
Memory. */
+#define PCI_DEV_RDM_CHECK   0x1
+struct xen_guest_pcidev_info {
+    uint8_t bus;
+    uint8_t devfn;
+    uint32_t    flags;
+};
+typedef struct xen_guest_pcidev_info xen_guest_pcidev_info_t;
+DEFINE_XEN_GUEST_HANDLE(xen_guest_pcidev_info_t);
+/* Control whether/how we check and reserve device memory. */
+struct xen_domctl_set_rdm {
+    uint32_t    flags;
+    uint32_t    num_pcidevs;
+    XEN_GUEST_HANDLE_64(xen_guest_pcidev_info_t) pcidevs;
+};
+typedef struct xen_domctl_set_rdm xen_domctl_set_rdm_t;
+DEFINE_XEN_GUEST_HANDLE(xen_domctl_set_rdm_t);
+
 /* Retrieve sibling devices infomation of machine_sbdf */
 /* XEN_DOMCTL_get_device_group */
 struct xen_domctl_get_device_group {

Thanks
Tiejun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel