Re: [Xen-devel] [PATCH OSSTEST v2 13/20] Osstest/Debian: Install dtbs into target filesystem in /boot/dtbs

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("[PATCH OSSTEST v2 13/20] Osstest/Debian: Install dtbs 
into target filesystem in /boot/dtbs"):
> This is done whenever dtbs.tar.gz exists. mg-debian-installer-update produces
> the necessary inputs on the relevant platform (armhf).

This patch looks good except for one quibble:

> +    if ( -e "$d_i/dtbs.tar.gz" ) {

If stat fails with EIO or something, this will proceed as if the dtb
doesn't exist.  This is generally a problem with perl's -e things.  I
would use stat and check $! if stat gives false.

See eg the lstat in TestSupport.pm:file_link_contents.  (You probably
want stat rather than lstat.)

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel