Re: [Xen-devel] [v7][RFC][PATCH 01/13] introduce XENMEM_reserved_device_memory_map

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 27.10.14 at 03:11, <tiejun.chen@xxxxxxxxx> wrote:
> On 2014/10/24 22:11, Jan Beulich wrote:
>>>>> On 24.10.14 at 09:34, <tiejun.chen@xxxxxxxxx> wrote:
>>> From: Jan Beulich <jbeulich@xxxxxxxx>
>>>
>>> This is a prerequisite for punching holes into HVM and PVH guests' P2M
>>> to allow passing through devices that are associated with (on VT-d)
>>> RMRRs.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>> Signed-off-by: Tiejun Chen <tiejun.chen@xxxxxxxxx>
>>
>> I'm confused - you dropped Kevins ack and instead added you S-o-b
> 
> I need to add this ACK.
> 
>> despite you not having changed anything in the patch.
> 
> The original you sent to me previously is needed to rebase on the 
> latest. Please check xen/include/public/memory.h.
> 
> The original:
> 
> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -573,7 +573,29 @@ struct vnuma_topology_info {
>   typedef struct vnuma_topology_info vnuma_topology_info_t;
>   DEFINE_XEN_GUEST_HANDLE(vnuma_topology_info_t);
> 
> -/* Next available subop number is 27 */
> 
> Mine:
> 
> --- a/xen/include/public/memory.h
> +++ b/xen/include/public/memory.h
> @@ -523,7 +523,29 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_sharing_
> 
>   #endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */
> 
> -/* Next available subop number is 26 */
> 
> Unless you're saying this kind of rebase shouldn't introduce my SOB.

I indeed don't think rebasing counts as you actively doing any
changes.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel