Re: [Xen-devel] [v7][RFC][PATCH 04/13] hvmloader/util: get reserved device memory maps

["Chen, Tiejun" <tiejun.chen@xxxxxxxxx>]

On 2014/10/24 22:27, Jan Beulich wrote:
> > > > On 24.10.14 at 09:34, <tiejun.chen@xxxxxxxxx> wrote:
> > --- a/tools/firmware/hvmloader/util.h
> > +++ b/tools/firmware/hvmloader/util.h
> > @@ -241,6 +241,12 @@ int build_e820_table(struct e820entry *e820,
> >                        unsigned int bios_image_base);
> >   void dump_e820_table(struct e820entry *e820, unsigned int nr);
> >
> > +#include <xen/memory.h>
> > +#define ENOBUFS     105 /* No buffer space available */
> > +struct xen_mem_reserved_device_memory *rdm_map;
> Oh, and - without "extern" this creates an instance in each
> translation unit (and would cause build failures the moment
> someone passed -fno-common to the compiler).
So instead, just define this in util.c then use this with 'extern'.

Thanks
Tiejun

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel