Re: [Xen-devel] [PATCH for-4.5] EFI: Always use EFI command line

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.10.14 at 02:16, <roy.franz@xxxxxxxxxx> wrote:
> There is no change in behavior for x86 since it unconditionally uses the 
> config file.

I'm afraid there is:

> @@ -904,8 +904,7 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE 
> *SystemTable)
>              efi_bs->FreePool(name.w);
>          }
>  
> -        name.s = get_value(&cfg, section.s, "options");
> -        efi_arch_handle_cmdline(argc ? *argv : NULL, options, name.s);
> +        cfg_options.s = get_value(&cfg, section.s, "options");
>  
>          if ( !base_video )
>          {

Between this and the below code fragments there is

        efi_bs->FreePages(cfg.addr, PFN_UP(cfg.size));

> @@ -930,8 +929,8 @@ efi_start(EFI_HANDLE ImageHandle, EFI_SYSTEM_TABLE 
> *SystemTable)
>          cfg.addr = 0;
>  
>          dir_handle->Close(dir_handle);
> -
>      }
> +    efi_arch_handle_cmdline(argc ? *argv : NULL, options, cfg_options.s);

i.e. you're accessing freed data here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel