Re: [Xen-devel] [PATCH] stubdom/Makefile should use QEMU_TRADITIONAL_LOC

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Oct 23, 2014 at 06:37:43PM +0100, M A Young wrote:
> In 
> http://xenbits.xenproject.org/gitweb/?p=xen.git;a=commit;h=8962a8f951ea83e8d10ee23aeb20266e4795b06e
> CONFIG_QEMU was replaced by QEMU_TRADITIONAL_LOC in several places but not
> in stubdom/Makefile, and as a result building stubdom is likely to fail when
> xen-setup-stubdom isn't found. This patch replaces CONFIG_QEMU with
> QEMU_TRADITIONAL_LOC in stubdom/Makefile as well.
> 

While I understand the rationale behind this change, I'm a bit confused
by the description. What does it mean by "is likely to fail"? Does it
mean it succeeds sometimes and fails sometimes?

What's your build setup? I'm wondering why this is not caught in
OSSTest.

Wei.

>       Michael Young

> In commit 8962a8f951ea83e8d10ee23aeb20266e4795b06e CONFIG_QEMU was replaced
> by QEMU_TRADITIONAL_LOC. However stubdom/Makefile still uses CONFIG_QEMU so
> building stubdom is likely to fail.
> This patch replaces CONFIG_QEMU with QEMU_TRADITIONAL_LOC in stubdom/Makefile
> as well.
> 
> Signed-off-by: Michael Young <m.a.young@xxxxxxxxxxxx>
> 
> --- xen-4.5.0/stubdom/Makefile.orig   2014-10-22 21:07:26.000000000 +0100
> +++ xen-4.5.0/stubdom/Makefile        2014-10-22 22:59:40.732112287 +0100
> @@ -263,7 +263,7 @@
>  .PHONY: $(CROSS_ROOT)
>  $(CROSS_ROOT): cross-newlib cross-zlib cross-libpci
>  
> -QEMU_ROOT := $(shell if [ -d "$(CONFIG_QEMU)" ]; then echo "$(CONFIG_QEMU)"; 
> else echo .; fi)
> +QEMU_ROOT := $(shell if [ -d "$(QEMU_TRADITIONAL_LOC)" ]; then echo 
> "$(QEMU_TRADITIONAL_LOC)"; else echo .; fi)
>  
>  ifneq ($(filter ioemu,$(STUBDOM_TARGETS)),)
>  IOEMU_LINKFARM_TARGET := ioemu/linkfarm.stamp

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxx
> http://lists.xen.org/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel