Re: [Xen-devel] [PATCH v2] Sanity check xsave area when migrating or restoring from older Xen verions

[Don Koch <dkoch@xxxxxxxxxxx>]

On Mon, 20 Oct 2014 16:28:47 +0100
Jan Beulich <JBeulich@xxxxxxxx> wrote:

> >>> On 20.10.14 at 14:54, <dkoch@xxxxxxxxxxx> wrote:
> > On Sat, 18 Oct 2014 00:36:28 +0100
> > Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> >> On 17/10/2014 18:11, Don Koch wrote:
> >> > +        for (int i = size; i < desc->length; i++)
> >> 
> >> Style
> > 
> > Is not really defined for "for". I checked the CODING_STYLE file and it only
> > defines style for "if" and "while".
> 
> Did you skip the "such as" in the section dealing with them?

Still not explicitly mentioned. I would have assumed they needed
spaces if it weren't for all the counterexamples.

> > I found more examples of "for" statements
> > with no spaces inside the parens; so, I went with that. Will fix.
> 
> It's not just about the missing spaces. You also shouldn't declare
> variables inside the for() statement.

This, too, wasn't mentioned at all in CODING_STYLES, but, of course, will
fix in my code (I had wondered about that, too).

> > Do you want me to update the CODING_STYLES file, too? (In a separate patch,
> > of course.)
> 
> As hinted at -  the document is sufficient as is afaict.
> 
> Jan

As hinted at - the document is lacking; too much is impliedn (at least, IMO).

-d

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel