Re: [Xen-devel] [OPW PATCH] tools/xl: Call init function for libxl_bitmap

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Sun, Oct 19, 2014 at 08:21:01PM +0530, Uma Sharma wrote:
> This patch calls init function for libxl_bitmap in
> main_cpupoolnumasplit() and vcpuset()
> tools/libxl/xl_cmdimpl.c
> IDL generated libxl types should be used only after calling the init
> function even if the variable is simply being passed by reference as
> an output parameter to a libxl function
> 
> Signed-off-by: Uma Sharma <uma.sharma523@xxxxxxxxx>

Acked-by: Wei Liu <wei.liu2@xxxxxxxxxx>

Presumably you're going to post a small series for your previous patch
and this one. Please carry this tag over.

> --
> diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c
> index 988ee28..d68223f 100644
> --- a/tools/libxl/xl_cmdimpl.c
> +++ b/tools/libxl/xl_cmdimpl.c
> @@ -4843,7 +4843,8 @@ static void vcpuset(uint32_t domid, const char* 
> nr_vcpus, int check_host)
>      char *endptr;
>      unsigned int max_vcpus, i;
>      libxl_bitmap cpumap;
> -
> +    
> +    libxl_bitmap_init(&cpumap);
>      max_vcpus = strtoul(nr_vcpus, &endptr, 10);
>      if (nr_vcpus == endptr) {
>          fprintf(stderr, "Error: Invalid argument.\n");
> @@ -7254,7 +7255,8 @@ int main_cpupoolnumasplit(int argc, char **argv)
>      }
>  
>      ret = 0;
> -
> +    
> +    libxl_bitmap_init(&cpumap);
>      poolinfo = libxl_list_cpupool(ctx, &n_pools);
>      if (!poolinfo) {
>          fprintf(stderr, "error getting cpupool info\n");

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel