Re: [Xen-devel] openfile handle to qemu-resume file

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

web1 writes ("[Xen-devel] openfile handle to qemu-resume file"):
...
>  if i look in the source code, i found in libxl_dm.c in the function 
> libxl__build_device_model_args_new that this "resume-file" is opened, but i 
> found no call to close this file . Later in libxl__spawn_local_dm (which 
> called libxl__build_device_model_args) i found a call to 
> device_model_spawn_outcome, their in the state-file is deleted (if it exists).

Thanks.  Yes, I think you are right.

> i don´t really understand while the state-file is open and not close before 
> delete. Can anyone that explain?

It looks like a bug to me.  I think the code in libxl here is quite
wrong.  I am preparing a patch to fix it.  (Sadly this is not entirely
trivial.)

> for one restore of a vm it is possilbe that this fact is not really 
> importent, but if you use libvirt in combination with xen/libxl it cause to 
> an increase of openfile handles , if you restore often vm´s for test´s

Indeed.  Thanks for the report and the analysis.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel