Re: [Xen-devel] [PATCH v13 for-xen-4.5 20/21] x86/VPMU: NMI-based VPMU support

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.10.14 at 23:40, <boris.ostrovsky@xxxxxxxxxx> wrote:
> +static void vpmu_send_interrupt(struct vcpu *v)
> +{
> +    struct vlapic *vlapic;
> +    u32 vlapic_lvtpc;
> +
> +    ASSERT( is_hvm_vcpu(v) );
> +
> +    vlapic = vcpu_vlapic(v);
> +    if ( !is_vlapic_lvtpc_enabled(vlapic) )
> +        return;
> +
> +    vlapic_lvtpc = vlapic_get_reg(vlapic, APIC_LVTPC);
> +    if ( GET_APIC_DELIVERY_MODE(vlapic_lvtpc) == APIC_MODE_FIXED )
> +        vlapic_set_irq(vcpu_vlapic(v), vlapic_lvtpc & APIC_VECTOR_MASK, 0);
> +    else
> +        v->nmi_pending = 1;

At the time you sent this the code you copied this from had already
changed (and I had pointed you to the cleanup patch in a reply to
the previous version) - I would really have expected you to base
your code on that.

> @@ -242,8 +280,9 @@ int vpmu_do_interrupt(struct cpu_user_regs *regs)
>                  else
>                      *flags |= PMU_SAMPLE_USER;
>              }
> -            else
> +            else if ( (vpmu_interrupt_type != APIC_DM_NMI) )

Bogus double parentheses.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel