Re: [Xen-devel] [PATCH RFC OSSTEST 11/19] standalone: Introduce "HostGroups" for use in OSSTEST_CONFIG

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-10-10 at 15:44 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH RFC OSSTEST 11/19] standalone: Introduce 
> "HostGroups" for use in OSSTEST_CONFIG"):
> > This saves repeating identical HostProp and HostFlags for sets of identical
> > machines. e.g.
> 
> The existing code is rather weird in that host properties from the
> configuration are dealt with in TestSupport (so apply to both
> standalone and executive), but host flags in the config are dealt with
> in HostDB/Static.pm (so apply only to standalone).

Yes, I noticed that... No reason for it, just hysterical raisins?

> > I was unsure whether HostGroupProp's ought to be processed before or
> > after the HostDB properties, but since the latter is a NOP I've
> > arbitrarily put them before.
> 
> The HostDB properties are not a NOP if the HostDB isn't Static!

Sorry, I meant for the Static HostDB, on the basis that I don't think
you would use the config file with the proper DB, would you?

(which might argue for moving a bunch of code from TestSupport to
HostDB/Static.pm?)

> In general the configuration should override the database.  So I think
> this is the wrong way round.

Ack.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel