Re: [Xen-devel] [PATCH v4] Separate runtime debug output from debug symbols

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 09/10/14 15:07, Jan Beulich wrote:
>>>> Olaf Hering <olaf@xxxxxxxxx> 10/09/14 9:59 AM >>>
>> --- a/Config.mk
>> +++ b/Config.mk
>> @@ -18,7 +18,7 @@ or       = $(if $(strip $(1)),$(1),$(if $(strip 
>> $(2)),$(2),$(if $(strip $(3)),$(
>  >
>> # A debug build of Xen and tools?
>> debug ?= y
>> -debug_symbols ?= $(debug)
>> +debug_symbols ?= y
>  
> Even if this may be what Ian asked you to do (albeit it's not entirely clear
> to me), I don't think I'm in agreement with this change being done: I
> personally expect to be able to disable debug_symbols as a side effect
> of disabling debug.
>
> Jan

Agreed, which is why I (as the author of the debug_symbols change) left
it that way.

FWIW, I believe that v3 of this patch is correct.  I did not follow the
reasoning for the objection.

Anyone building for themselves will (should) be doing debug builds. 
Anyone packaging RPMs will want debug_symbols enabled to generate
-debuginfo RPMs.  I presume .debs have a similar principle.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel