Re: [Xen-devel] [PATCH] libxl: Fix error handling in libxl_userdata_unlink

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Andrew Cooper writes ("Re: [Xen-devel] [PATCH] libxl: Fix error handling in 
libxl_userdata_unlink"):
> On 24/09/14 15:30, Ian Jackson wrote:
> > (CCing security@ because they receive the Coverity reports.  This is
> > not a security problem AFAICT.)
> 
> How about coverty@ which includes some of us not on securty@ ?

Yes.

> > -    libxl__domain_userdata_lock *lock;
> > +    int rc;
> > +    libxl__domain_userdata_lock *lock = 0;
> 
> Pointers should be initialised to NULL rather than 0.

Changed.

> With this change, Reviewed-by: Andrew Cooper<andrew.cooper3@xxxxxxxxxx>

Now pushed (with Ian C's ack, also).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel