Re: [Xen-devel] [RFC PATCH 10/13] xen: arm: implement platform hypercall

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Oleksandr,

On 10/07/2014 03:19 PM, Oleksandr Dmytryshyn wrote:
> +ret_t do_platform_op(XEN_GUEST_HANDLE_PARAM(xen_platform_op_t) u_xenpf_op)
> +{
> +    ret_t ret = 0;
> +    struct xen_platform_op curop, *op = &curop;
> +
> +    if ( copy_from_guest(op, u_xenpf_op, 1) )
> +        return -EFAULT;
> +
> +    if ( op->interface_version != XENPF_INTERFACE_VERSION )
> +        return -EACCES;

Why did you drop the XSM check here?

Overall, the skeleton of this function is very similar to the x86. I
would move the common part in xen/common and add arch implementation
when it's necessary. You can give a look to do_domctl and arch_do_domctl.

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel