Re: [Xen-devel] [RFC PATCH 06/13] cpufreq: make cpufreq driver more generalizable

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 07.10.14 at 16:19, <oleksandr.dmytryshyn@xxxxxxxxxxxxxxx> wrote:
> @@ -207,6 +213,18 @@ int cpufreq_add_cpu(unsigned int cpu)
>                  );
>              return -EINVAL;
>          }
> +#else /* CONFIG_ACPI */
> +        if ((perf->domain_info.num_processors !=
> +            processor_pminfo[firstcpu]->perf.domain_info.num_processors)) {
> +
> +            printk(KERN_WARNING "cpufreq fail to add CPU%d:"
> +                   "incorrect _PSD(%"PRIu64"), expect(%"PRIu64")\n",
> +                   cpu, perf->domain_info.num_processors,
> +                   
> processor_pminfo[firstcpu]->perf.domain_info.num_processors
> +                );
> +            return -EINVAL;
> +        }
> +#endif /* CONFIG_ACPI */

This seems rather arbitrary: What is _PSD outside of ACPI or a similar
spec? If you want to generalize the file, please truly do so.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel