Re: [Xen-devel] [PATCH 2/2] xen/arm: Use PSCI-0.2 for machine_halt/restart by default

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Suravee,

On 10/01/2014 09:02 PM, suravee.suthikulpanit@xxxxxxx wrote:
>  void machine_halt(void)
>  {
> +    int timeout = 10;
> +
>      watchdog_disable();
>      console_start_sync();
>      local_irq_enable();
>      smp_call_function(halt_this_cpu, NULL, 0);
> +    local_irq_disable();
> +
> +    /* Wait at most another 10ms for all other CPUs to go offline. */
> +    while ( (num_online_cpus() > 1) && (timeout-- > 0) )
> +        mdelay(1);
> +

This doesn't look like PSCI specific. Can you explain in the commit
message why you need to add this new block of code?

Regards,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel