Re: [Xen-devel] [PATCH v7 for-xen-4.5 1/2] dpci: Move from an hvm_irq_dpci (and struct domain) to an hvm_dirq_dpci model.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 29.09.14 at 12:16, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 27/09/14 02:33, Konrad Rzeszutek Wilk wrote:
>> @@ -526,13 +561,17 @@ static int _hvm_dirq_assist(struct domain *d, struct 
>> hvm_pirq_dpci *pirq_dpci,
>>              send_guest_pirq(d, pirq);
>>  
>>              if ( pirq_dpci->flags & HVM_IRQ_DPCI_GUEST_MSI )
>> -                return 0;
>> +            {
>> +                spin_unlock(&d->event_lock);
>> +                return;
>> +            }
> 
> perhaps "goto out_unlock;" ?  It would help identify any return
> statements as bogus while the lock is held.

I know there are differing opinions on the use of goto in situations
like this, but I'm rather happy that Konrad went the goto-free
route.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel