Re: [Xen-devel] [PATCH for-4.5 v20 07/12] xl/remus: change bool to defbool

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

On Fri, Sep 26, 2014 at 12:38:49AM +0100, Ian Jackson wrote:
> Shriram Rajagopalan writes ("Re: [Xen-devel] [PATCH for-4.5 v20 07/12] 
> xl/remus: change bool to defbool"):
> > On Sep 25, 2014 3:21 PM, "Konrad Rzeszutek Wilk" <konrad.wilk@xxxxxxxxxx>
> > wrote:
> > > On Thu, Sep 25, 2014 at 02:16:19PM +0800, Yang Hongyang wrote:
> > > > Use defbool instead of bool for boolean flags in remus_info struct.
> > >
> > > While that change by itself looks OK, the change in 'libxl_types.idl'
> > > break the ABI.
> 
> (We don't provide ABI stability in libxl (across Xen releases), only
> API stability.  However, this change does break the API too:)
> 
> > > Could you say a bit of why that is OK? As in, would there had
> > > been in the past any users of this ABI that now would have issues with 
> > > this?
> >
> > There were no users of the libxl Remus api in the past. Certainly not an API
> > level user like libvirt.
> 
> This is IMO a good answer.  As I said earlier, the libxl Remus API in
> previous version does not really work properly so it seems unlikely
> that this change will break any uses.
> 
> > > Also, how important is this patch? Does it have to go in or
> > > can it be dropped from the patchset?
> > 
> > Well, this defbool thing came up as part of the feedback.
> 
> Ian C and I think that this variable should be a defbool.  That it
> wasn't, beforehand, was a mistake.  We have an opportinity to fix that
> now, but we won't after 4.5 if we release working libxl Remus support
> in 4.5 (as we intend.)

OK, defbool it is. Thank you for clearing that up.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel