Re: [Xen-devel] [PATCH for-4.5 2/2] x86/hvm: Improve "Emulation failed @" error messages

[Tim Deegan <tim@xxxxxxx>]

At 11:10 +0100 on 26 Sep (1411726207), Andrew Cooper wrote:
> +static const char *guest_x86_mode_to_str(int mode)
> +{
> +    switch ( mode )
> +    {
> +    case 0:
> +        return "Real";
> +    case 1:
> +        return "v8086";
> +    case 2:

return "16bit"?  

Otherwise, Reviewed-by: Tim Deegan <tim@xxxxxxx>

While you're respinning, could you also shorten all of these strings
(e.g. to real/vm86/16b/32b/64b), and trim the rest of the line,
something like:

(d1) MMIO emulation failed: d1v0 64b @ 0008:ffff82d080102fea: 48 63 8d 40 ff ff 
ff

You can keep the reviewed-by regardless of whatever cosmetic changes.

Cheers,

Tim.

> +    case 4:
> +        return "32bit";
> +    case 8:
> +        return "64bit";
> +    default:
> +        return "Unknown";

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel