Re: [Xen-devel] [PATCH for-4.5 V6 01/14] move x86 EFI boot/runtime code to common/efi

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 24.09.14 at 07:02, <roy.franz@xxxxxxxxxx> wrote:
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -100,6 +100,10 @@ $(TARGET): delete-unfresh-files
>       $(MAKE) -C tools
>       $(MAKE) -f $(BASEDIR)/Rules.mk include/xen/compile.h
>       [ -e include/asm ] || ln -sf asm-$(TARGET_ARCH) include/asm
> +     [ -e arch/$(TARGET_ARCH)/efi ] && ln -nsf ../../../common/efi/boot.c 
> arch/$(TARGET_ARCH)/efi/;\
> +                     ln -nsf ../../../common/efi/runtime.c 
> arch/$(TARGET_ARCH)/efi/;\
> +                     ln -nsf ../../../common/efi/compat.c 
> arch/$(TARGET_ARCH)/efi/;\
> +                     ln -nsf ../../../common/efi/efi.h 
> arch/$(TARGET_ARCH)/efi/;

I don't think this does what you want: The && applies only to the first
ln invocation, the others will be done unconditionally. And this would
be better done with "for f in boot.c runtime.c ..." anyway, at which
point the issue magically disappears.

Furthermore (I'm sorry for not paying attention to the before) you
shouldn't use && in make rules without some extra care: If the left
side evaluates to false, the whole compound command (and hence
the make rule) will fail. Either use || or invoke /bin/true as last
operation.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel