Re: [Xen-devel] [OSSTEST PATCH RFC v1 10/12] make-flight: create XSM test jobs

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2014-09-22 at 15:11 +0100, Wei Liu wrote:
> @@ -214,13 +224,13 @@ do_hvm_debian_tests() {
>  
>    # QEMU upstream supports ovmf and seabios
>    if [ "x$qemuu_suffix" == "x-qemuu" ]; then
> -    do_hvm_debian_test_one ovmf ovmf
> -    do_hvm_debian_test_one debianhvm seabios
> +    do_hvm_debian_test_one ovmf ovmf false
> +    do_hvm_debian_test_one debianhvm seabios true

I think it would be less repetitive to duplicate these lines as
necessary rather than duping the job creation inside these functions. So
e.g.:
+    do_hvm_debian_test_one ovmf ovmf false
+    do_hvm_debian_test_one debianhvm seabios false
+    do_hvm_debian_test_one debianhvm seabios true

>    # Basic PV Linux test with xl
>  
>    job_create_test test-$xenarch$kern-$dom0arch-xl test-debian xl \
>              $xenarch $dom0arch                                   \
> +            enable_xsm=n                                         \
>              $debian_runvars all_hostflags=$most_hostflags
>  
> +  if [ x$test_xsm = xy ] ; then
> +      job_create_test test-$xenarch$kern-$dom0arch-xl-xsm test-debian xl \
> +              $xenarch $dom0arch                                   \
> +              enable_xsm=y                                         \
> +              $debian_runvars all_hostflags=$most_hostflags
> +  fi

Refactor this into a fnction and call it a second time?

> +
>    job_create_test test-$xenarch$kern-$dom0arch-libvirt test-debian libvirt \
>              $xenarch $dom0arch                                       \
>              $debian_runvars all_hostflags=$most_hostflags



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel