Re: [Xen-devel] [PATCH for-4.5 v3 2/3] xen: add helpers for PDX mask initialisation calculations

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hi Ian,

On 17/09/14 14:21, Ian Campbell wrote:
> +/* Sets all bits from the most-significant 1-bit down to the LSB */
> +static u64 __init fill_mask(u64 mask)
> +{
> +        while (mask & (mask + 1))
> +                mask |= mask + 1;
> +        return mask;
> +}
> +
> +u64 pdx_init_mask(u64 base_addr)

[..]

> +u64 pdx_region_mask(u64 base, u64 len)
fill_mask is marked as __init. For consistency, those 2 functions should 
be marked too.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel