[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v4 06/16] xen: Convert vmware_port to xentrace usage




On 09/12/14 09:10, Boris Ostrovsky wrote:
On 09/11/2014 02:36 PM, Don Slutz wrote:
@@ -2080,6 +2080,14 @@ static void svm_vmexit_gp_intercept(struct cpu_user_regs *regs,
      inst_len = __get_instruction_length_from_list(
          v, list, ARRAY_SIZE(list), 0);
  +    if ( hvm_long_mode_enabled(v) )
+        HVMTRACE_LONG2_C4D(TRAP_GP, inst_len, regs->rdx,
+                           TRC_PAR_LONG(vmcb->exitinfo1),
+                           TRC_PAR_LONG(vmcb->exitinfo2));
+    else
+ HVMTRACE_C4D(TRAP_GP, inst_len, vmcb->exitinfo1, vmcb->exitinfo1,
+                     vmcb->exitinfo2);

exitinfo1 is used twice. Did you mean regs->rdx for one of them?


Yes.  Will fix.
Thanks,
    -Don Slutz

-boris

+
      rc = vmport_gp_check(regs, v, inst_len, inst_addr,
                           vmcb->exitinfo1, vmcb->exitinfo2);
      if ( !rc )



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.