Re: [Xen-devel] [PATCH V4 12/15] Add efi_arch_use_config_file() function to control use of config file

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Thu, 11 Sep 2014, Jan Beulich wrote:
> >>> On 10.09.14 at 02:52, <roy.franz@xxxxxxxxxx> wrote:
> > -    cols = rows = depth = 0;
> > -    if ( !base_video )
> > -    {
> > -        name.cs = get_value(&cfg, section.s, "video");
> > -        if ( !name.cs )
> > -            name.cs = get_value(&cfg, "global", "video");
> > -        if ( name.cs && !strncmp(name.cs, "gfx-", 4) )
> > +        cols = rows = depth = 0;
> > +        if ( !base_video )
> >          {
> > -            cols = simple_strtoul(name.cs + 4, &name.cs, 10);
> > -            if ( *name.cs == 'x' )
> > -                rows = simple_strtoul(name.cs + 1, &name.cs, 10);
> > -            if ( *name.cs == 'x' )
> > -                depth = simple_strtoul(name.cs + 1, &name.cs, 10);
> > -            if ( *name.cs )
> > -                cols = rows = depth = 0;
> > +            name.cs = get_value(&cfg, section.s, "video");
> > +            if ( !name.cs )
> > +                name.cs = get_value(&cfg, "global", "video");
> > +            if ( name.cs && !strncmp(name.cs, "gfx-", 4) )
> > +            {
> > +                cols = simple_strtoul(name.cs + 4, &name.cs, 10);
> > +                if ( *name.cs == 'x' )
> > +                    rows = simple_strtoul(name.cs + 1, &name.cs, 10);
> > +                if ( *name.cs == 'x' )
> > +                    depth = simple_strtoul(name.cs + 1, &name.cs, 10);
> > +                if ( *name.cs )
> > +                    cols = rows = depth = 0;
> > +            }
> 
> So how is this video mode selection being represented then without
> config file? Don't you need to at least add a command line option for
> that?

The scenario without config file is the one where Xen is loaded by GRUB.
Do we actually need to pass a video mode option in that case?
Wouldn't GRUB take care of changing video mode itself to the value
specified by the user before booting Xen? Xen can query the current
video mode afterwards.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel