Re: [Xen-devel] [PATCH v1 15/21] Powerpc/MSI: Use MSI chip framework to configure MSI/MSI-X irq

[Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>]

On 9/5/2014 3:33 PM, wangyijing wrote:

> > > Use MSI chip framework instead of arch MSI functions to configure
> > > MSI/MSI-X irq. So we can manage MSI/MSI-X irq in a unified framework.
> > > Signed-off-by: Yijing Wang <wangyijing@xxxxxxxxxx>
> > > ---
> > >   arch/powerpc/kernel/msi.c |   14 ++++++++++++--
> > >   1 files changed, 12 insertions(+), 2 deletions(-)
> > > diff --git a/arch/powerpc/kernel/msi.c b/arch/powerpc/kernel/msi.c
> > > index 71bd161..01781a4 100644
> > > --- a/arch/powerpc/kernel/msi.c
> > > +++ b/arch/powerpc/kernel/msi.c
> > [...]
> > > @@ -27,7 +27,17 @@ int arch_setup_msi_irqs(struct pci_dev *dev, int nvec, int 
> > > type)
> > >       return ppc_md.setup_msi_irqs(dev, nvec, type);
> > >   }
> > >
> > > -void arch_teardown_msi_irqs(struct pci_dev *dev)
> > > +static void ppc_teardown_msi_irqs(struct pci_dev *dev)
> >    Shouldn't this function take IRQ # instead?
> This function need to teardown all msi irqs of the pci dev, we should pass the 
> pci dev as argument .
   Ah, I've mixed up the teardown_irqs() method with teardown_irq()! Too 
similar. :-)
> Thanks!
> Yijing.
WBR, Sergei


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel