Re: [Xen-devel] [PATCH RFC 7/9] xen: arm: handle variable p2m levels in apply_p2m_changes

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

(sorry for the delay replying)

On Tue, 2014-08-26 at 14:41 +0530, Vijay Kilari wrote:
> On Mon, Aug 11, 2014 at 12:30 PM, Vijay Kilari <vijay.kilari@xxxxxxxxx> wrote:
> > On Wed, Jul 30, 2014 at 7:17 PM, Ian Campbell <ian.campbell@xxxxxxxxxx> 
> > wrote:
> >> @@ -726,9 +699,27 @@ static int apply_p2m_changes(struct domain *d,
> >>
> >>      spin_lock(&p2m->lock);
> >>
> >> +    if ( P2M_ROOT_PAGES == 1 )
> >> +    {
> >> +        /* Static mapping. P2M_ROOT_PAGES > 1 are handled below */
> >> +        mappings[P2M_ROOT_LEVEL] = __map_domain_page(p2m->root);
> >> +        {
> >> +            rc = -EINVAL;
> 
> Commenting below lines of code, where forcibly jumping to out if
> P2M_ROOT_PAGES==1
> I could boot my system with 48-bit PA
> 
>         mappings[P2M_ROOT_LEVEL] = __map_domain_page(p2m->root);
>         /*{
>             printk("In %s line %d\n",__func__, __LINE__);
>             rc = -EINVAL;
>             goto out;
>         }*/

Yeah, that block was totally bogus, not sure what I was thinking!

I suspect I meant to put an "if (!mappings[P2M_ROOT_LEVEL])" before it
but forget (or lost it during a rebase somehow), but as Julien points
out elsewhere map_domain_page cannot fail, so I've just nuked it like
you did.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel