Re: [Xen-devel] [v5][PATCH 09/10] tools:firmware:hvmloader: check to reserve RMRR mappings in e820

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.09.14 at 09:12, <tiejun.chen@xxxxxxxxx> wrote:
> On 2014/9/4 14:36, Jan Beulich wrote:
>>>>> On 04.09.14 at 05:04, <tiejun.chen@xxxxxxxxx> wrote:
>>> On 2014/9/2 16:47, Jan Beulich wrote:
>>>>>>> On 26.08.14 at 13:02, <tiejun.chen@xxxxxxxxx> wrote:
>>>>> +    unsigned int insert = 0, do_insert = 0;
>>>>> +
>>>>> +do_real_construct:
>>>>
>>>> Please indent labels by at least one space (and there are further
> 
> Sorry I may be misunderstanding here.
> 
> +
> +do_real_construct:
> +    for ( i = 0; i < nr_map; i++ )
> +    {

I still don't get what you're trying to tell me - in the suggested new
code fragment the label is a un-indented as it was in the original
one. This is how it should look like:

+ do_real_construct:
+    for ( i = 0; i < nr_map; i++ )
+    {

The point here being that the patch context generation (-p option
to classical patch) otherwise takes the label rather than the
function name as context for a change below that line, yet label
(other than function) names can repeat within a source file, making
patch reviewing (slightly) less efficient.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel