Re: [Xen-devel] [PATCH v3 15/15] tools/tests: Enable xen-access on ARM

[Julien Grall <julien.grall@xxxxxxxxxx>]

Hello Tamas,

On 01/09/14 10:22, Tamas K Lengyel wrote:
> diff --git a/tools/tests/xen-access/Makefile b/tools/tests/xen-access/Makefile
> index 65eef99..698355c 100644
> --- a/tools/tests/xen-access/Makefile
> +++ b/tools/tests/xen-access/Makefile
> @@ -7,9 +7,7 @@ CFLAGS += $(CFLAGS_libxenctrl)
>   CFLAGS += $(CFLAGS_libxenguest)
>   CFLAGS += $(CFLAGS_xeninclude)
>
> -TARGETS-y :=
> -TARGETS-$(CONFIG_X86) += xen-access
> -TARGETS := $(TARGETS-y)
> +TARGETS := xen-access
I would move the definition of HAS_MEM_ACCESS from arch/*/Rules.mk to 
config/*.mk and use the defition here to build or not xen-access.
> @@ -520,7 +551,7 @@ int main(int argc, char *argv[])
>
>               /* Unregister for every event */
>               rc = xc_set_mem_access(xch, domain_id, XENMEM_access_rwx, ~0ull, 
> 0);
> -            rc = xc_set_mem_access(xch, domain_id, XENMEM_access_rwx, 0,
> +            rc = xc_set_mem_access(xch, domain_id, XENMEM_access_rwx, 
> GUEST_RAM_BASE_PFN,
>                                      xenaccess->domain_info->max_pages);
ARM may contains multiple banks non-contiguous banks. On Xen 4.5, there 
is 2 banks with a hole (see GUEST_RAM{0,1}_* in 
xen/include/public/arch-arm.h).
This change won't work with guest using more than 3G of RAM.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel